Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ban std.debug.assert #10168

Merged
merged 17 commits into from
Apr 12, 2024
Merged

refactor: ban std.debug.assert #10168

merged 17 commits into from
Apr 12, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

  • ban std.debug.assert
  • add a very primitive way for banned methods in the codebase to cause CI to fail

How did you verify your code works?

CI

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited
Loading

✅ lint failures have been resolved. Thank you.

#5aa34c6789a9de0cd929b0624e30355a2bf3f614

@Jarred-Sumner Jarred-Sumner marked this pull request as ready for review April 11, 2024 12:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited
Loading

❌ @Jarred-Sumner 3 files with test failures on linux-x64-baseline:

View test output

#5aa34c6789a9de0cd929b0624e30355a2bf3f614

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited
Loading

❌ @Jarred-Sumner 3 files with test failures on linux-x64:

View test output

#5aa34c6789a9de0cd929b0624e30355a2bf3f614

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited
Loading

❌ @Jarred-Sumner 2 files with test failures on bun-darwin-aarch64:

View test output

#5aa34c6789a9de0cd929b0624e30355a2bf3f614

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024 •
edited
Loading

❌ @Jarred-Sumner 3 files with test failures on bun-darwin-x64:

View test output

#5aa34c6789a9de0cd929b0624e30355a2bf3f614

nektro
nektro approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@nektro nektro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can't wait to add more! nice work on this

edit: where's the comment for the windows CI ?

@github-actions GitHub Actions
Copy link
Contributor

❌ @Jarred-Sumner 9 files with test failures on bun-windows-x86_64-haswell

View test output

#5aa34c6789a9de0cd929b0624e30355a2bf3f614

@Jarred-Sumner Jarred-Sumner merged commit 688844b into main Apr 12, 2024
27 of 32 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/aassert branch April 12, 2024 00:52
cirospaciari pushed a commit that referenced this pull request Apr 14, 2024
@Jarred-Sumner @cirospaciari
refactor: ban std.debug.assert (#10168)
2178381 
* Ban `std.debug.assert`

* Create .clangd

* Update lint.yml

* Update linter.ts

* update

* lint

* Update linter.ts

* Update linter.ts

* update

* Update linter.ts

* update

* Update linter.ts

* more

* Update install.zig

* words

* Remove UB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nektro nektro nektro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jarred-Sumner @nektro